Review Request 109489: fix grayed avatars part 1/2

Martin Klapetek martin.klapetek at gmail.com
Fri Mar 15 09:58:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109489/#review29261
-----------------------------------------------------------

Ship it!


I did a quick investigation - avatarTokenChanged() is emitted when we connect and it's not when we go offline or the contact goes offline.


contactnotify.cpp
<http://git.reviewboard.kde.org/r/109489/#comment21881>

    Remove this as well


- Martin Klapetek


On March 14, 2013, 11:25 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109489/
> -----------------------------------------------------------
> 
> (Updated March 14, 2013, 11:25 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Martin Klapetek.
> 
> 
> Description
> -------
> 
> avatars cached keys for offline contacts are wiped out when you login. this patch fixes that.
> 
> 
> This addresses bug 316743.
>     http://bugs.kde.org/show_bug.cgi?id=316743
> 
> 
> Diffs
> -----
> 
>   contactnotify.cpp 4dd3249 
> 
> Diff: http://git.reviewboard.kde.org/r/109489/diff/
> 
> 
> Testing
> -------
> 
> checked the rc file and the avatars are correctly stored.
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130315/39111876/attachment.html>


More information about the KDE-Telepathy mailing list