Review Request 108571: Allow a separate config for group chats

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108571/#review29259
-----------------------------------------------------------



config/appearance-config-tab.h
<http://git.reviewboard.kde.org/r/108571/#comment21874>

    You've told me so many times, that magic booleans suck :) Also the parent should be second argument as is ordinary. +Coding style.



config/appearance-config-tab.h
<http://git.reviewboard.kde.org/r/108571/#comment21875>

    Variable names missing



config/appearance-config-tab.cpp
<http://git.reviewboard.kde.org/r/108571/#comment21876>

    Star alignment



config/appearance-config-tab.cpp
<http://git.reviewboard.kde.org/r/108571/#comment21877>

    & alignment



config/appearance-config-tab.cpp
<http://git.reviewboard.kde.org/r/108571/#comment21878>

    This should have i18nc as the message above



config/appearance-config-tab.cpp
<http://git.reviewboard.kde.org/r/108571/#comment21879>

    Same here and few more down



config/appearance-config-tab.cpp
<http://git.reviewboard.kde.org/r/108571/#comment21880>

    Should this be translatable?



config/appearance-config.h
<http://git.reviewboard.kde.org/r/108571/#comment21872>

    Star to the right



config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/108571/#comment21873>

    Star alignment


- Martin Klapetek


On March 15, 2013, 1:46 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108571/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 1:46 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Allow a separate config for group chats
> 
> Work by our code-in student Huba Nagy. I've not reviewed it myself.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp 9a014e35c67d20b8fa3fc98049f7e2fb3f4a5317 
>   config/CMakeLists.txt 24e9e80ffd9c23515a457a5d2f0ba8271e207e17 
>   config/appearance-config-tab.h PRE-CREATION 
>   config/appearance-config-tab.cpp PRE-CREATION 
>   config/appearance-config.h 48bd67aaad5e31c7e5409447b2d4f807f9542748 
>   config/appearance-config.cpp 247b47defb151f46d5a2f672002a1096e7567e91 
>   config/appearance-config.ui a6d55a2d9d0e9ae4b1b05fb389893c07c2fbf8d2 
>   lib/adium-theme-view.h 5775432619e3b9c3759221fb1a91780cd4583079 
>   lib/adium-theme-view.cpp f58beb630966ed046d2a90381b526cd0945dc8fe 
>   lib/chat-widget.cpp 6cfbce60ce4d924f53585eb329074d64e504846c 
> 
> Diff: http://git.reviewboard.kde.org/r/108571/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130315/f1917d29/attachment-0001.html>