Review Request 109490: fix grayed avatars part 2/2

Alin M Elena alinm.elena at gmail.com
Fri Mar 15 08:00:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109490/
-----------------------------------------------------------

(Updated March 15, 2013, 8 a.m.)


Review request for Telepathy, David Edmundson and Martin Klapetek.


Changes
-------

updated diff to be consistent with my last comment on keyCache()

I have also renamed avatarToken variable to avatarHash as this is what it is. 


Description
-------

using avatarToken for keyCache ends up with "-offline" for all grayed avatars as cache entries.. which is obviously wrong... I used id() instead... Martin's original idea.


This addresses bug 316743.
    http://bugs.kde.org/show_bug.cgi?id=316743


Diffs (updated)
-----

  KTp/contact.h 32af16b 
  KTp/contact.cpp 84ae642 

Diff: http://git.reviewboard.kde.org/r/109490/diff/


Testing
-------

build and now offline avatars are correctly grayed.


Thanks,

Alin M Elena

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130315/3fd89094/attachment.html>


More information about the KDE-Telepathy mailing list