Review Request 108571: Allow a separate config for group chats
Daniele E. Domenichelli
daniele.domenichelli at gmail.com
Fri Mar 15 07:53:57 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108571/#review29254
-----------------------------------------------------------
config/appearance-config-tab.h
<http://git.reviewboard.kde.org/r/108571/#comment21868>
Extra spaces (all around the file)
config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/108571/#comment21867>
Perhaps "Single User Chat" sounds better?
config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/108571/#comment21869>
You lost these changes to the demo chat, so now the status messages are not hidden when you check the button
- Daniele E. Domenichelli
On March 15, 2013, 1:46 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108571/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 1:46 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Allow a separate config for group chats
>
> Work by our code-in student Huba Nagy. I've not reviewed it myself.
>
>
> Diffs
> -----
>
> app/chat-window.cpp 9a014e35c67d20b8fa3fc98049f7e2fb3f4a5317
> config/CMakeLists.txt 24e9e80ffd9c23515a457a5d2f0ba8271e207e17
> config/appearance-config-tab.h PRE-CREATION
> config/appearance-config-tab.cpp PRE-CREATION
> config/appearance-config.h 48bd67aaad5e31c7e5409447b2d4f807f9542748
> config/appearance-config.cpp 247b47defb151f46d5a2f672002a1096e7567e91
> config/appearance-config.ui a6d55a2d9d0e9ae4b1b05fb389893c07c2fbf8d2
> lib/adium-theme-view.h 5775432619e3b9c3759221fb1a91780cd4583079
> lib/adium-theme-view.cpp f58beb630966ed046d2a90381b526cd0945dc8fe
> lib/chat-widget.cpp 6cfbce60ce4d924f53585eb329074d64e504846c
>
> Diff: http://git.reviewboard.kde.org/r/108571/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130315/0aa34f46/attachment.html>
More information about the KDE-Telepathy
mailing list