Review Request 109432: Store contact's avatar tokens in config file for using when contact is offline

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109432/
-----------------------------------------------------------

(Updated March 14, 2013, 12:35 p.m.)


Review request for Telepathy.


Changes
-------

Check when contact goes offline to not store empty token


Description
-------

This stores the avatar tokens in a config file, which can be reused in KTp::Contact::avatar() - if we don't have avatar available from Tp, we check the config file and see if we have cached token. This will be another patch.

I think this will have problems with Gtalk's contact ids like 235jb7ggtg01m20rtksena9sa1 at public.talk.google.com - I'm not sure if these are auto-generated from some key or what, but if each connection generates new id, then this will be quite useless.

EDIT: I missed the telepathy-module.cpp in the diff where it adds the AvatarToken feature.


This addresses bug 315939.
    http://bugs.kde.org/show_bug.cgi?id=315939


Diffs (updated)
-----

  contactnotify.h 9018114 
  contactnotify.cpp ad82a73 
  telepathy-module.cpp 1c986b1 

Diff: http://git.reviewboard.kde.org/r/109432/diff/


Testing
-------

Config file properly stored.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130314/1d9cb479/attachment-0001.html>