Review Request 109460: Part 2/2 of offline avatars patch

Martin Klapetek martin.klapetek at gmail.com
Thu Mar 14 12:34:36 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109460/
-----------------------------------------------------------

(Updated March 14, 2013, 12:34 p.m.)


Review request for Telepathy.


Changes
-------

Load the cached avatar only when the contact is offline


Description
-------

Adds loading the avatar in KTp::Contact::avatar(). The config part might need adjusting. Also keyCache() is unreliable because we can't rely on avatarToken being present in the features, so I changed it to contact id instead.


Diffs (updated)
-----

  KTp/contact.h da4f895 
  KTp/contact.cpp 26c8847 

Diff: http://git.reviewboard.kde.org/r/109460/diff/


Testing
-------

Works.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130314/9b2a8514/attachment.html>


More information about the KDE-Telepathy mailing list