Review Request 109460: Part 2/2 of offline avatars patch

[Martin Klapetek]

> On March 14, 2013, 11:40 a.m., David Edmundson wrote:
> > KTp/contact.cpp, line 149
> > <http://git.reviewboard.kde.org/r/109460/diff/2/?file=119610#file119610line149>
> >
> >     this change isn't needed now right?

I think it is, because you have no guarantee the avatarToken feature is present, so the pixmapcache will then contain only "-offline" without avatarToken feature. On the other hand this will be called only for the pawn icons, so it's actually a fortunate bug as it stores only one pixmap of that pawn and always return that one. So...dunno.


> On March 14, 2013, 11:40 a.m., David Edmundson wrote:
> > KTp/contact.cpp, line 171
> > <http://git.reviewboard.kde.org/r/109460/diff/2/?file=119610#file119610line171>
> >
> >     QString::fromLatin1
> >     
> >     not QString(QLatin1String())
> >     
> >     everywhere in this method.

Copied from Collabora masters... :P


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109460/#review29195
-----------------------------------------------------------


On March 13, 2013, 4:24 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109460/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 4:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds loading the avatar in KTp::Contact::avatar(). The config part might need adjusting. Also keyCache() is unreliable because we can't rely on avatarToken being present in the features, so I changed it to contact id instead.
> 
> 
> Diffs
> -----
> 
>   KTp/contact.h da4f895 
>   KTp/contact.cpp 26c8847 
> 
> Diff: http://git.reviewboard.kde.org/r/109460/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130314/a6342f4f/attachment.html>