Review Request 109466: Fixed crash on KAction unreferencing after detaching tab

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109466/
-----------------------------------------------------------

(Updated March 13, 2013, 5:54 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Description
-------

09:00 pm <d_ed> ok, imagine you have the setting "open tabs in a new window'
09:00 pm <d_ed> you open window 1
09:00 pm <d_ed> it gets the right action, things are good
09:00 pm <d_ed> you open window 2
09:00 pm <d_ed> you get the action for the first window
09:00 pm <d_ed> things still work
09:00 pm <d_ed> you close window 1
09:00 pm <d_ed> that KAction* is now deleted
09:00 pm <d_ed> you type in window 2.. crash

Fixed by using local KShortcut objects in every TextEdit widget.


This addresses bug 316484.
    http://bugs.kde.org/show_bug.cgi?id=316484


Diffs
-----

  app/chat-window.h a92cb75 
  app/chat-window.cpp 02a390e 
  lib/chat-text-edit.h 7611924 
  lib/chat-text-edit.cpp 00c3f47 
  lib/chat-widget.h 9eecc89 
  lib/chat-widget.cpp 4416d68 

Diff: http://git.reviewboard.kde.org/r/109466/diff/


Testing
-------


Thanks,

Roman Nazarenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130313/3b3fe6dd/attachment.html>