Review Request 109460: Part 2/2 of offline avatars patch
David Edmundson
david at davidedmundson.co.uk
Wed Mar 13 13:43:24 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109460/#review29125
-----------------------------------------------------------
KTp/contact.cpp
<http://git.reviewboard.kde.org/r/109460/#comment21746>
No mixing the word "token" and filePaths.
Tbh, storing the token kinda makes more sense.
- David Edmundson
On March 13, 2013, 12:49 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109460/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 12:49 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Adds loading the avatar in KTp::Contact::avatar(). The config part might need adjusting. Also keyCache() is unreliable because we can't rely on avatarToken being present in the features, so I changed it to contact id instead.
>
>
> Diffs
> -----
>
> KTp/contact.cpp 26c8847
>
> Diff: http://git.reviewboard.kde.org/r/109460/diff/
>
>
> Testing
> -------
>
> Works.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130313/b7d7c187/attachment-0001.html>
More information about the KDE-Telepathy
mailing list