Review Request 109445: Fix linking issue with qjson <= 0.7.1

Commit Hook null at kde.org
Tue Mar 12 07:40:46 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109445/
-----------------------------------------------------------

(Updated March 12, 2013, 7:40 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Description
-------

build would fail with
/build/buildd/ktp-auth-handler-0.6.0+git20130310+r86/x-messenger-oauth2-prompt.cpp:203: undefined reference to `QJson::Parser::Parser()'
/build/buildd/ktp-auth-handler-0.6.0+git20130310+r86/x-messenger-oauth2-prompt.cpp:206: undefined reference to `QJson::Parser::parse(QByteArray const&, bool*)'
/build/buildd/ktp-auth-handler-0.6.0+git20130310+r86/x-messenger-oauth2-prompt.cpp:232: undefined reference to `QJson::Parser::~Parser()

because /usr/lib/x86_64-linux-gnu/cmake/qjson/qjson-config.cmake ships lower case prefixed defines:
SET(qjson_LIBRARIES "/usr/lib/x86_64-linux-gnu/libqjson.so" CACHE FILEPATH "Libraries for qjson")
SET(qjson_INCLUDE_DIR "/usr/include" CACHE PATH "Include path for qjson")
SET(qjson_FOUND "TRUE")

i still wonder why qjson_FOUND works though.


This addresses bug 316564.
    http://bugs.kde.org/show_bug.cgi?id=316564


Diffs
-----

  cmake/modules/FindQJSON.cmake fad59050d8df1326d07fa6aacac1eb31346f67ba 

Diff: http://git.reviewboard.kde.org/r/109445/diff/


Testing
-------

Build successfull on ubuntu 12.10 with quantal


Thanks,

Florian Reinhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130312/ca1e37ec/attachment-0001.html>


More information about the KDE-Telepathy mailing list