Review Request 109432: Store contact's avatar tokens in config file for using when contact is offline

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109432/#review29044
-----------------------------------------------------------



contactnotify.cpp
<http://git.reviewboard.kde.org/r/109432/#comment21719>

    contact->id() is not unique
    
    we need something like:
    
    account->uniqueId + '_' + contact->id();
    
    
    Does mean putting the method in Contact::avatar() is harder...



contactnotify.cpp
<http://git.reviewboard.kde.org/r/109432/#comment21721>

    does a group for each contact make sense - the lookup will be faster, no?
    
    otherwise each contact is going to have to load the entire list then get the data it wants.
    


I also want to see patched KTp::Contact and KTp::PersistentContact before this merges.

- David Edmundson


On March 11, 2013, 6:56 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109432/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 6:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This stores the avatar tokens in a config file, which can be reused in KTp::Contact::avatar() - if we don't have avatar available from Tp, we check the config file and see if we have cached token. This will be another patch.
> 
> I think this will have problems with Gtalk's contact ids like 235jb7ggtg01m20rtksena9sa1 at public.talk.google.com - I'm not sure if these are auto-generated from some key or what, but if each connection generates new id, then this will be quite useless.
> 
> EDIT: I missed the telepathy-module.cpp in the diff where it adds the AvatarToken feature.
> 
> 
> This addresses bug 315939.
>     http://bugs.kde.org/show_bug.cgi?id=315939
> 
> 
> Diffs
> -----
> 
>   contactnotify.h 9018114 
>   contactnotify.cpp ad82a73 
>   telepathy-module.cpp 1c986b1 
> 
> Diff: http://git.reviewboard.kde.org/r/109432/diff/
> 
> 
> Testing
> -------
> 
> Config file properly stored.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130312/48c2b55d/attachment-0001.html>