Review Request 109429: Stop the spinner only after all the accounts are connected

David Edmundson david at davidedmundson.co.uk
Tue Mar 12 00:31:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109429/#review29041
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On March 11, 2013, 5:13 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109429/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 5:13 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Currently the spinner on the presence chooser stops spinning as soon as the first account is connected. But it should be stopped only after all accounts are connected. GlobalPresence does signal that (onConnectionChanged(..)), so let's just use that.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp f748197 
> 
> Diff: http://git.reviewboard.kde.org/r/109429/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130312/651fd875/attachment.html>


More information about the KDE-Telepathy mailing list