Review Request 109347: fixes deprecated warning

David Edmundson david at davidedmundson.co.uk
Fri Mar 8 20:17:41 UTC 2013



> On March 8, 2013, 2:55 p.m., David Edmundson wrote:
> > CMakeLists.txt, line 7
> > <http://git.reviewboard.kde.org/r/109347/diff/1/?file=117834#file117834line7>
> >
> >     [14:53] <d_ed_> alin:  I'm a bit worried about it
> >     [14:53] <d_ed_> it means if KDE 4.11 deprecate something, our stuff fails to build
> >     [14:54] <d_ed_> until we make a new release
> >     
> >     That's not good.
> 
> Aleix Pol Gonzalez wrote:
>     I agree, although making sure that developers keep deprecated to a minimum would be interesting.

++ I'd be happy with this applied to Jenkins only.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109347/#review28807
-----------------------------------------------------------


On March 8, 2013, 6:24 a.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109347/
> -----------------------------------------------------------
> 
> (Updated March 8, 2013, 6:24 a.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Martin Klapetek.
> 
> 
> Description
> -------
> 
> fix deprecated warning... comes from using old kde functions...
> 
> 
> This addresses bug 316320.
>     http://bugs.kde.org/show_bug.cgi?id=316320
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a6591f5 
> 
> Diff: http://git.reviewboard.kde.org/r/109347/diff/
> 
> 
> Testing
> -------
> 
> compiles with -Werror -std=c++11
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130308/89933846/attachment.html>


More information about the KDE-Telepathy mailing list