Review Request 109183: Show bugzilla bug information directly in the UI (a bit like bugbot)

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109183/#review28722
-----------------------------------------------------------

Ship it!


Also I see the license is GPL, but all our code is supposed to be LGPL. Dunno about other filters, but should be fixed eventually.


filters/bugzilla/bugzilla-filter.cpp
<http://git.reviewboard.kde.org/r/109183/#comment21476>

    this is somewhat misleading name of the property, can we make something like "requestId" or just "requestCounter"



filters/bugzilla/bugzilla-filter.cpp
<http://git.reviewboard.kde.org/r/109183/#comment21474>

    put the { on a new line, it's confusing me



filters/bugzilla/bugzilla-filter.cpp
<http://git.reviewboard.kde.org/r/109183/#comment21475>

    somewhat useless comment (the same is stated below)


- Martin Klapetek


On March 6, 2013, 9:15 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109183/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 9:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add a new filter that turns messages containg bugzilla bug URL's into displaying the full title + status (lasath)
> Move bugzilla querying into the client (me)
> 
> This allows everything to happen asynchronously, meaning we don't block the UI and we can show the message instantly
> 
> It demos that we don't need message processor to be async, which greatly simplifies things.
> 
> 
> Also removed some invalid linker lines.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt dd2d088106ed28e68baafd4ad6c2080ee6231fd3 
>   filters/bugzilla/CMakeLists.txt PRE-CREATION 
>   filters/bugzilla/bugzilla-filter.h PRE-CREATION 
>   filters/bugzilla/bugzilla-filter.cpp PRE-CREATION 
>   filters/bugzilla/ktptextui_message_filter_bugzilla.desktop.cmake PRE-CREATION 
>   filters/bugzilla/showBugzillaInfo.js PRE-CREATION 
>   filters/emoticons/CMakeLists.txt 780f8cb5206283794c07bdcf1a0571fea666c4ab 
>   filters/formatting/CMakeLists.txt fd803795b762056c73892827b4f7c62e91de4d9c 
>   filters/images/CMakeLists.txt 0b9548f519104d9d1cf1ff2600ada281337f278d 
>   filters/texttospeech/CMakeLists.txt 7116a8544e9a2a9bf7b68c3508211b877fad0b21 
> 
> Diff: http://git.reviewboard.kde.org/r/109183/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/9bd615bb/attachment.html>