Review Request 109313: set version in CMakeLists.txt

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109313/#review28694
-----------------------------------------------------------

Ship it!



src/dialout/main.cpp
<http://git.reviewboard.kde.org/r/109313/#comment21459>

    This is exactly the reason we're doing this change :)
    
    Well done on spotting this !


- David Edmundson


On March 6, 2013, 3:55 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109313/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 3:55 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> set version in CMakeLists.txt and use it in all the places that had version hardcoded...
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 365cb44 
>   src/dialout/main.cpp 1448d55 
>   src/main.cpp d9ebd0f 
>   version.h.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109313/diff/
> 
> 
> Testing
> -------
> 
> build and installed checked both call-ui and dialout that have the right version string
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/cd0a9846/attachment.html>