Review Request 109313: set version in CMakeLists.txt
David Edmundson
david at davidedmundson.co.uk
Wed Mar 6 15:30:00 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109313/#review28691
-----------------------------------------------------------
Do a find and replace :)
CMakeLists.txt
<http://git.reviewboard.kde.org/r/109313/#comment21455>
this isn't the text-ui
src/dialout/main.cpp
<http://git.reviewboard.kde.org/r/109313/#comment21458>
and here
src/main.cpp
<http://git.reviewboard.kde.org/r/109313/#comment21457>
and here
version.h.in
<http://git.reviewboard.kde.org/r/109313/#comment21456>
and here
- David Edmundson
On March 6, 2013, 3:24 p.m., Alin M Elena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109313/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 3:24 p.m.)
>
>
> Review request for Telepathy and David Edmundson.
>
>
> Description
> -------
>
> set version in CMakeLists.txt and use it in all the places that had version hardcoded...
>
>
> Diffs
> -----
>
> CMakeLists.txt 365cb44
> src/dialout/main.cpp 1448d55
> src/main.cpp d9ebd0f
> version.h.in PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/109313/diff/
>
>
> Testing
> -------
>
> build and installed checked both call-ui and dialout that have the right version string
>
>
> Thanks,
>
> Alin M Elena
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/9cd19cf9/attachment-0001.html>
More information about the KDE-Telepathy
mailing list