Review Request 109312: Move version information to CMakeLists.txt
Aleix Pol Gonzalez
aleixpol at gmail.com
Wed Mar 6 15:25:25 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109312/#review28690
-----------------------------------------------------------
CMakeLists.txt
<http://git.reviewboard.kde.org/r/109312/#comment21454>
Why do you pass ${CMAKE_CURRENT_SOURCE_DIR}? You don't need to pass an absolute directory...
- Aleix Pol Gonzalez
On March 6, 2013, 2:39 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109312/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 2:39 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Move version information to CMakeLists.txt
>
>
> Diffs
> -----
>
> CMakeLists.txt 1fc0e3b2437536b9dde657bed591f0f6cc7dec90
> plasma-runner-ktp-contact.desktop 1fd6302b45e51c8597191ae77133c90cfdfde8b4
> plasma-runner-ktp-contact.desktop.cmake PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/109312/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/cc4be40f/attachment.html>
More information about the KDE-Telepathy
mailing list