Review Request 109308: Stop new lines appearing on sending messages

Commit Hook null at kde.org
Wed Mar 6 13:00:09 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109308/#review28681
-----------------------------------------------------------


This review has been submitted with commit 9140828cce75056f8cb17a5cd354babdf34c10bd by David Edmundson to branch master.

- Commit Hook


On March 6, 2013, 2:57 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109308/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 2:57 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Stop new lines appearing on sending messages
> 
> Previous code _always_ added a newline on the end. This was because it's set to go to HTML and whitespace there does not matter.
> 
> In 0.7 unless Lasath still argues, I will probably make a new class for PendingOutgoingMessages which only have the methods it needs and doesn't have these sorts of problems.
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.cpp aa2db083b868aa3ef82286bb2632640f3788eee6 
> 
> Diff: http://git.reviewboard.kde.org/r/109308/diff/
> 
> 
> Testing
> -------
> 
> Sent messages.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/43e6e5ad/attachment-0001.html>


More information about the KDE-Telepathy mailing list