Review Request 109307: Declarative Plugin: Overload file sending for url's

[David Edmundson]

> On March 6, 2013, 11:26 a.m., Martin Klapetek wrote:
> > KTp/Declarative/declarative-ktp-actions.h, line 45
> > <http://git.reviewboard.kde.org/r/109307/diff/2/?file=117195#file117195line45>
> >
> >     pointer signs to the right in argument
> 
> Aleix Pol Gonzalez wrote:
>     It's like the rest of the methods in this class...
> 
> Martin Klapetek wrote:
>     Yes because you forgot it the first time :P Will fix.

That wasn't Apol who wrote it.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109307/#review28664
-----------------------------------------------------------


On March 6, 2013, 2:45 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109307/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 2:45 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Let the module understand URL's as well. Otherwise it was translated into a string and telepathy wouldn't understand the file:// thing.
> 
> Also this opens the possibility of implementing KIO properly, eventually.
> 
> Maybe this should go into KTp::Action, but I'm unsure.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/declarative-ktp-actions.cpp 4e8eeee 
>   KTp/Declarative/declarative-ktp-actions.h 034bcd2 
>   KTp/actions.h d825bae 
>   KTp/actions.cpp 2e2ae5e 
> 
> Diff: http://git.reviewboard.kde.org/r/109307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/a6480638/attachment-0001.html>