Review Request 109307: Declarative Plugin: Overload file sending for url's

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109307/#review28664
-----------------------------------------------------------



KTp/Declarative/declarative-ktp-actions.h
<http://git.reviewboard.kde.org/r/109307/#comment21428>

    pointer signs to the right in argument



KTp/Declarative/declarative-ktp-actions.cpp
<http://git.reviewboard.kde.org/r/109307/#comment21429>

    ...here as well



KTp/actions.h
<http://git.reviewboard.kde.org/r/109307/#comment21424>

    pointer alignment of the arguments to the right, just remember it already! :P



KTp/actions.cpp
<http://git.reviewboard.kde.org/r/109307/#comment21425>

    pointer sign alignments



KTp/actions.cpp
<http://git.reviewboard.kde.org/r/109307/#comment21426>

    Tp::PendingOperation* ret -> Tp::PendingOperation *ret



KTp/actions.cpp
<http://git.reviewboard.kde.org/r/109307/#comment21427>

    if( -> if (
    
    plus {}


- Martin Klapetek


On March 6, 2013, 2:45 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109307/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 2:45 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Let the module understand URL's as well. Otherwise it was translated into a string and telepathy wouldn't understand the file:// thing.
> 
> Also this opens the possibility of implementing KIO properly, eventually.
> 
> Maybe this should go into KTp::Action, but I'm unsure.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/declarative-ktp-actions.cpp 4e8eeee 
>   KTp/Declarative/declarative-ktp-actions.h 034bcd2 
>   KTp/actions.h d825bae 
>   KTp/actions.cpp 2e2ae5e 
> 
> Diff: http://git.reviewboard.kde.org/r/109307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/4d46c7f8/attachment.html>