Review Request 109309: Use theme to highlight messages

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109309/#review28658
-----------------------------------------------------------

Ship it!


Looks great! Does this remove the extra end of line as well?

- Daniele E. Domenichelli


On March 6, 2013, 4:13 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109309/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 4:13 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Use theme to highlight messages
> 
> Rather than hardcoding red, pass a special messageClass to the theme which highlights it for us
> Looks better, and is theme dependant.
> 
> 
> Diffs
> -----
> 
>   filters/highlight/highlight-filter.cpp f58a0bbd520319786442b01dc0f2c11b0f230f39 
>   filters/highlight/ktptextui_message_filter_highlight.desktop.cmake d60558a8bb7821a9f5dcd5c6910918bd8f53391d 
>   lib/chat-widget.cpp aa2db083b868aa3ef82286bb2632640f3788eee6 
> 
> Diff: http://git.reviewboard.kde.org/r/109309/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/06/ktp_mention.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/efd17a5e/attachment.html>