Review Request 109304: Chat plasmoid: Polish sizes

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109304/#review28640
-----------------------------------------------------------


This review has been submitted with commit 3bd4b7e5a814953ef9175610e50e43170b3b8faf by Aleix Pol to branch master.

- Commit Hook


On March 6, 2013, 1:13 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109304/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 1:13 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> I noticed there was a problem where the plasmoid would get the minimum size at some point and started to investigate. It turned out that there was an ugly property loop between the minimumSize and the plasmoid's size. I guess QML is not reporting it because it happens in the Plasma side.
> 
> What this patch does is to make sure that we let the plasmoid's width/height be 0 when it's empty.
> 
> Also it reads the form factor and in case it's horizontal, it uses the horizontal flow, despite its size.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/main.qml 9cd0ed5 
> 
> Diff: http://git.reviewboard.kde.org/r/109304/diff/
> 
> 
> Testing
> -------
> 
> I added a bunch of console.log and considered it didn't loop anymore
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/10edb6b9/attachment.html>