Review Request 109134: Chat plasmoid: Improve placement of the dialog

[Aleix Pol Gonzalez]

> On March 5, 2013, 7:26 p.m., David Edmundson wrote:
> > chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml, line 63
> > <http://git.reviewboard.kde.org/r/109134/diff/3/?file=117072#file117072line63>
> >
> >     Shouldn't we just show the dialog in Component.onComplete?
> >     
> >     and in onVisibleChanged if it's not ready do nothing?

We are already doing so in: ConversationDelegate.qml:42, and it doesn't work.

Since I don't want to be told that I don't look for alternatives, I tried using a timer, and it works too. I don't like the patch that much, though: http://paste.ubuntu.com/5589169


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109134/#review28612
-----------------------------------------------------------


On March 5, 2013, 2:04 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109134/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 2:04 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Place the dialog by the plasmoid instead of 0,0 in case the button's delegate hasn't been set up yet or there was a problem finding out the position.
> 
> It's good because a dialog at 0,0 looks really odd.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml de44494 
> 
> Diff: http://git.reviewboard.kde.org/r/109134/diff/
> 
> 
> Testing
> -------
> 
> just start a conversation from a pinned button and you'll see it looks funny...
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/fc42250a/attachment.html>