Review Request 109301: fix auto away not restoring previous presence the first time

David Edmundson david at davidedmundson.co.uk
Tue Mar 5 23:35:20 UTC 2013



> On March 5, 2013, 11:34 p.m., David Edmundson wrote:
> > Nice

I have a feeling I've asked this before. Do you have commit access?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109301/#review28630
-----------------------------------------------------------


On March 5, 2013, 11:21 p.m., Stefan Eggers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109301/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 11:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> fix auto away not restoring previous presence the first time
> 
> Adds a missing initialization of a member variable which caused auto
> away to not properly restore the previous presence once it turns off.
> 
> 
> This addresses bug 301335.
>     http://bugs.kde.org/show_bug.cgi?id=301335
> 
> 
> Diffs
> -----
> 
>   telepathy-module.cpp b52be1f32d93672338d65c42bccecbe3fee854b6 
> 
> Diff: http://git.reviewboard.kde.org/r/109301/diff/
> 
> 
> Testing
> -------
> 
> - Make sure you are online.
> - Log out.
> - Log in.
> - Wait till auto away kicks in.
> - Move mouse.
> 
> Without this fix presence stays in status away. With this fix it gets restored to online.
> 
> 
> Thanks,
> 
> Stefan Eggers
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130305/0d246872/attachment.html>


More information about the KDE-Telepathy mailing list