Review Request 109296: Fix compiler warning

Martin Klapetek martin.klapetek at gmail.com
Tue Mar 5 21:12:58 UTC 2013



> On March 5, 2013, 8:30 p.m., Aleix Pol Gonzalez wrote:
> > contact-list-widget.cpp, line 333
> > <http://git.reviewboard.kde.org/r/109296/diff/1/?file=117131#file117131line333>
> >
> >     don't you prefer "int(Qt::DisplayRole)"?
> >     
> >     I think it is easier to read.

Depends, I'm personally more used to (int) as that's what's taught in all c++ books. Up to you David.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109296/#review28613
-----------------------------------------------------------


On March 5, 2013, 8:27 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109296/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 8:27 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix compiler warning
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.cpp 85d7132658d639976501295a53fafbb5cd475361 
> 
> Diff: http://git.reviewboard.kde.org/r/109296/diff/
> 
> 
> Testing
> -------
> 
> Compiled :)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130305/25dce266/attachment.html>


More information about the KDE-Telepathy mailing list