Review Request 109289: Adds exclusive actions group for contact list grouping

[Roman Nazarenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109289/
-----------------------------------------------------------

(Updated March 5, 2013, 3:17 p.m.)


Review request for Telepathy.


Changes
-------

Added enumerated action groups, so we could easily convert checked grouped action into appearance modes. 
Those groups also allow us to replace onFullView/onNormalView slots with one onAppearanceChanged(int), so we can reduce number of manual signal-slot connections (and improve readability and maintainability). 

Also moved (config file option name <-> widget text <-> mode enumerator) relations for exclusive action groups into separate static class MenuConfig, so we can avoid manual relations tracking.


Description (updated)
-------

Adds exclusive actions group for contact list grouping.
Added enumerated action groups, so we could easily convert checked grouped action into appearance modes. 
Those groups also allow us to replace onFullView/onNormalView slots with one onAppearanceChanged(int), so we can reduce number of manual signal-slot connections (and improve readability and maintainability). 

Also moved (config file option name <-> widget text <-> mode enumerator) relations for exclusive action groups into separate static class MenuConfig, so we can avoid manual relations tracking.


This addresses bug 279023.
    http://bugs.kde.org/show_bug.cgi?id=279023


Diffs (updated)
-----

  CMakeLists.txt 5802d32 
  action-group-enumerated.h PRE-CREATION 
  action-group-enumerated.cpp PRE-CREATION 
  contact-list-widget.h ab2191c 
  contact-list-widget.cpp f931913 
  main-widget.h d72c970 
  main-widget.cpp 778c71e 

Diff: http://git.reviewboard.kde.org/r/109289/diff/


Testing
-------


Thanks,

Roman Nazarenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130305/ff0d30c5/attachment.html>