Review Request 109134: Chat plasmoid: Improve placement of the dialog

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109134/
-----------------------------------------------------------

(Updated March 5, 2013, 2:04 p.m.)


Review request for Telepathy.


Changes
-------

Improved version of the patch, instead of checking the result of popupPosition, pass the correct item automatically.

It still fixes the problem and the code is hopefully nicer.

/me crosses fingers and hopes David will like it better


Description
-------

Place the dialog by the plasmoid instead of 0,0 in case the button's delegate hasn't been set up yet or there was a problem finding out the position.

It's good because a dialog at 0,0 looks really odd.


Diffs (updated)
-----

  chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml de44494 

Diff: http://git.reviewboard.kde.org/r/109134/diff/


Testing
-------

just start a conversation from a pinned button and you'll see it looks funny...


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130305/d0b0aa20/attachment.html>