Review Request 109183: Show bugzilla bug information directly in the UI (a bit like bugbot)

[David Edmundson]

> On March 1, 2013, 12:45 p.m., Martin Klapetek wrote:
> > filters/bugzilla/bugzilla-filter.h, line 32
> > <http://git.reviewboard.kde.org/r/109183/diff/1/?file=116021#file116021line32>
> >
> >     Varname here. I see it's not used in many (all?) filters, should it just be (re)moved?

The QVariantList argument is compulsory for a KDE Plugin.


> On March 1, 2013, 12:45 p.m., Martin Klapetek wrote:
> > filters/bugzilla/bugzilla-filter.cpp, line 66
> > <http://git.reviewboard.kde.org/r/109183/diff/1/?file=116022#file116022line66>
> >
> >     Should we put the link also between the "..></a>" (as a display text)?

That's populated by the JSON query with the bug name and details.

also if did we put a link there this filter does nothing other than take bugzilla links, and move them to the end...which would be silly.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109183/#review28252
-----------------------------------------------------------


On Feb. 26, 2013, 6:09 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109183/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 6:09 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add a new filter that turns messages containg bugzilla bug URL's into displaying the full title + status (lasath)
> Move bugzilla querying into the client (me)
> 
> This allows everything to happen asynchronously, meaning we don't block the UI and we can show the message instantly
> 
> It demos that we don't need message processor to be async, which greatly simplifies things.
> 
> 
> Also removed some invalid linker lines.
> 
> 
> Diffs
> -----
> 
>   filters/images/CMakeLists.txt 33bdbc9 
>   filters/texttospeech/CMakeLists.txt 8f25696 
>   filters/formatting/CMakeLists.txt 1bb818c 
>   filters/emoticons/CMakeLists.txt 5054e8d 
>   filters/bugzilla/showBugzillaInfo.js PRE-CREATION 
>   filters/bugzilla/ktptextui_message_filter_bugzilla.desktop PRE-CREATION 
>   filters/bugzilla/bugzilla-filter.h PRE-CREATION 
>   filters/bugzilla/bugzilla-filter.cpp PRE-CREATION 
>   filters/bugzilla/CMakeLists.txt PRE-CREATION 
>   filters/CMakeLists.txt d21f619 
> 
> Diff: http://git.reviewboard.kde.org/r/109183/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130305/0fa0e786/attachment.html>