Review Request 109289: Adds exclusive actions group for contact list grouping

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109289/#review28574
-----------------------------------------------------------



contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/109289/#comment21355>

    Why don't we pass KTp::ContactsModel::GroupMode as the arg type. It's safer, and we don't need to cast.



contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/109289/#comment21357>

    You need this line to reset the filter bar



contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/109289/#comment21356>

    alternate way to fix the compile warning
    
    
    d->model->setSortRole(sort ? (int) KTp::ContactPresenceTypeRole : (int)Qt::DisplayRole);
    
    
    (not tested)
    
    They get casted to an int for setSortRole anyway


If you think the saving code is messy (though I'm happy with it) you can also look at setting the group mode in the action->data() of the 3 grouping actions. 
Then on shutdown save actionGroup->checkedAction->data(); ... or we can just expose the current group mode from contact list widget and save that instead of fetching data from the action.

- David Edmundson


On March 5, 2013, 7:36 a.m., Roman Nazarenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109289/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 7:36 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds exclusive actions group for contact list grouping.
> Depends on this fix: https://git.reviewboard.kde.org/r/109288/
> 
> writing config on destruction is dirty, don't know how do I fix it without adding new main widget properties.
> 
> 
> This addresses bug 279023.
>     http://bugs.kde.org/show_bug.cgi?id=279023
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h ab2191c 
>   contact-list-widget.cpp f931913 
>   main-widget.h d72c970 
>   main-widget.cpp 778c71e 
> 
> Diff: http://git.reviewboard.kde.org/r/109289/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Nazarenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130305/6b84cf91/attachment.html>