Review Request 109288: Fixed build warnings for common-internals. Also partially fixes contact-list build warning

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109288/#review28573
-----------------------------------------------------------



KTp/types.h
<http://git.reviewboard.kde.org/r/109288/#comment21354>

    This is not the right way to fix this.
    
    If we went with this approach we'd also need to copy Qt::DecorationRole Qt::EnabledRole and so on. It's a bodge to work round a wrong warning in the contact list.


- David Edmundson


On March 5, 2013, 6:59 a.m., Roman Nazarenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109288/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 6:59 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix for 'unused variables' warning.
> Fix for 'enum mismatch' warning in contact-list. 
> 
> 
> Diffs
> -----
> 
>   KTp/types.h 82ccbb6 
>   tests/roles-proxy-model.cpp 6a0c3e1 
> 
> Diff: http://git.reviewboard.kde.org/r/109288/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Nazarenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130305/bb45e021/attachment.html>