Review Request 109275: Split the display name and the contacts count in the header delegate

[Martin Klapetek]

> On March 4, 2013, 7:11 p.m., David Edmundson wrote:
> > Ship it from me, if Martin K is happy

Martin K is unhappy with the groupRect.adjust(BORDER, BORDER, -BORDER, -BORDER -1);. I'll do proper review tomorrow, was moving to Barcelona today, so sorry for not doing it sooner.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109275/#review28552
-----------------------------------------------------------


On March 3, 2013, 9:52 p.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109275/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 9:52 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Description
> -------
> 
> Split the display name and the contacts count in the header delegate
> 
> The contacts count was elided with the display name, and therefore not displayed when the text is elided.
> 
> Also fixes a few small problems:
> 
> * The text was elided in a rect that was for some reason sometime smaller and sometimes bigger than the available area.
> * Add one point for the gray line in the bottom.
> * Play a little bit with spacing, borders and size hints to make it prettier and easier to understand.
> 
> 
> This addresses bugs 316089 and 316090.
>     http://bugs.kde.org/show_bug.cgi?id=316089
>     http://bugs.kde.org/show_bug.cgi?id=316090
> 
> 
> Diffs
> -----
> 
>   abstract-contact-delegate.cpp 8b70eedec97c381c30e99ee31c82d1ab9ba6dee5 
> 
> Diff: http://git.reviewboard.kde.org/r/109275/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> ktp-contact-list with separate display name and contacts count
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/03/snapshot117.png
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130304/b36b563f/attachment.html>