Review Request 109280: Grouping is now disabled during contacts search

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109280/#review28543
-----------------------------------------------------------



contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/109280/#comment21302>

    If I'm right this has a bug:
    
    set group mode to groupByAccount
    
    search
    (d->groupMode = groupByAccount)
    
    stop searching
    
    (d->groupMode remains the same)
    
    set group mode to NoGrouping in the UI
    
    search
    
    (d->groupMode remains the same)
    
    stop searching
    
      - we now change the grouping to GroupByAccount even though it should be NoGrouping.
    
    
    
    


- David Edmundson


On March 4, 2013, 1:18 p.m., Roman Nazarenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109280/
> -----------------------------------------------------------
> 
> (Updated March 4, 2013, 1:18 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> When there is something in filter bar, contact list goes flat. It restores its state when filter bar is either empty or hidden.
> 
> 
> This addresses bug 291445.
>     http://bugs.kde.org/show_bug.cgi?id=291445
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.cpp 85d7132 
>   contact-list-widget_p.h 03a7f1b 
> 
> Diff: http://git.reviewboard.kde.org/r/109280/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Nazarenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130304/72ce3616/attachment-0001.html>