Review Request 109279: fixes bad quality for grayed avatars (offline)

David Edmundson david at davidedmundson.co.uk
Mon Mar 4 12:23:43 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109279/#review28537
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On March 4, 2013, 12:21 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109279/
> -----------------------------------------------------------
> 
> (Updated March 4, 2013, 12:21 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson, Dan Vrátil, and Martin Klapetek.
> 
> 
> Description
> -------
> 
> it seems that saving the mask from the pixmap and restoring it is not a good idea... I have saved the alpha channel instead and now we have crisp and nice grayed avatars.
> 
> 
> This addresses bug 316109.
>     http://bugs.kde.org/show_bug.cgi?id=316109
> 
> 
> Diffs
> -----
> 
>   KTp/contact.cpp 0bc891d 
> 
> Diff: http://git.reviewboard.kde.org/r/109279/diff/
> 
> 
> Testing
> -------
> 
> checked in contact list and they are nice now
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130304/33e3b040/attachment.html>


More information about the KDE-Telepathy mailing list