Review Request 109275: Split the display name and the contacts count in the header delegate
Daniele E. Domenichelli
daniele.domenichelli at gmail.com
Sun Mar 3 21:52:44 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109275/
-----------------------------------------------------------
(Updated March 3, 2013, 9:52 p.m.)
Review request for Telepathy and Martin Klapetek.
Description
-------
Split the display name and the contacts count in the header delegate
The contacts count was elided with the display name, and therefore not displayed when the text is elided.
Also fixes a few small problems:
* The text was elided in a rect that was for some reason sometime smaller and sometimes bigger than the available area.
* Add one point for the gray line in the bottom.
* Play a little bit with spacing, borders and size hints to make it prettier and easier to understand.
This addresses bugs 316089 and 316090.
http://bugs.kde.org/show_bug.cgi?id=316089
http://bugs.kde.org/show_bug.cgi?id=316090
Diffs (updated)
-----
abstract-contact-delegate.cpp 8b70eedec97c381c30e99ee31c82d1ab9ba6dee5
Diff: http://git.reviewboard.kde.org/r/109275/diff/
Testing
-------
File Attachments
----------------
ktp-contact-list with separate display name and contacts count
http://git.reviewboard.kde.org/media/uploaded/files/2013/03/03/snapshot117.png
Thanks,
Daniele E. Domenichelli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130303/ce36fa29/attachment-0001.html>
More information about the KDE-Telepathy
mailing list