Review Request 109267: Address review comments
David Edmundson
david at davidedmundson.co.uk
Sun Mar 3 19:59:29 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109267/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
Add a class that keeps the latest Tp::ContactPtr for a given contact ID even across reconnections
Make PinnedContactModel use PersistentContact
This fixes a bug in which contact pointers would be invalid after reconnections
Hopefully also simplifies code
Diffs
-----
KTp/CMakeLists.txt a8c86fabec796afb2821c5129e0c105c4a2eea3f
KTp/Declarative/pinned-contacts-model.h 7f01961ae84483cee00a12894c21648c81428633
KTp/Declarative/pinned-contacts-model.cpp e5febfa74189fb2dd14cb0cb9918ebaeed74961c
KTp/persistent-contact.h PRE-CREATION
KTp/persistent-contact.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109267/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130303/86f489de/attachment.html>
More information about the KDE-Telepathy
mailing list