Review Request 109262: busyOverlay now hides if presence chooser is editable.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109262/#review28461
-----------------------------------------------------------

Ship it!



global-presence-chooser.cpp
<http://git.reviewboard.kde.org/r/109262/#comment21255>

    You don't need this check as this method won't be ever called before the constructor, which constructs this widget. But won't hurt either.



global-presence-chooser.cpp
<http://git.reviewboard.kde.org/r/109262/#comment21257>

    This needs to be called only when editable is false; also please add a comment that we're restarting the spinner if it was spinning before


- Martin Klapetek


On March 3, 2013, 4:55 p.m., Roman Nazarenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109262/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 4:55 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> busyOverlay now hides if presence chooser is editable.
> 
> 
> This addresses bug 292282.
>     http://bugs.kde.org/show_bug.cgi?id=292282
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.h d7a19c4 
>   global-presence-chooser.cpp 9e7994f 
> 
> Diff: http://git.reviewboard.kde.org/r/109262/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Nazarenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130303/ae6b35f7/attachment.html>