Review Request 109262: busyOverlay now hides if presence chooser is editable.

[David Edmundson]

> On March 3, 2013, 4:31 p.m., David Edmundson wrote:
> > global-presence-chooser.h, line 50
> > <http://git.reviewboard.kde.org/r/109262/diff/1/?file=116710#file116710line50>
> >
> >     We have a general rule of always putting "virtual" in the declaration when we override a method that's already virtual.
> >     
> >     I think it's more of a style thing.
> 
> Roman Nazarenko wrote:
>     Not only style. If we'll use this box with KComboBox* pointer, it won't work with this overlay properly due to unvirtual function.
>     I was actually just being confused a bit with virtuality (thought non-virtual functions behave as virtual ones really do and vice versa).
>     Fixed in new diff.

http://stackoverflow.com/questions/4895294/c-virtual-keyword-for-functions-in-derived-classes-is-it-necessary


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109262/#review28454
-----------------------------------------------------------


On March 3, 2013, 4:55 p.m., Roman Nazarenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109262/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 4:55 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> busyOverlay now hides if presence chooser is editable.
> 
> 
> This addresses bug 292282.
>     http://bugs.kde.org/show_bug.cgi?id=292282
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.h d7a19c4 
>   global-presence-chooser.cpp 9e7994f 
> 
> Diff: http://git.reviewboard.kde.org/r/109262/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Nazarenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130303/2cef45b9/attachment-0001.html>