Review Request 109232: ported cl to use avararPixmap part 2 (and last)

[Alin M Elena]

> On March 2, 2013, 9:32 p.m., Martin Klapetek wrote:
> > contact-delegate.cpp, line 96
> > <http://git.reviewboard.kde.org/r/109232/diff/3/?file=116609#file116609line96>
> >
> >     This adds the round square around the blue pawn, which is unwanted....?
> >     
> >     You might want to add a check for KTp::ContactAvatarPathRole being empty

actually I want the line around... was a long wish of mine...
I like all the avatars too have the same style


- Alin M


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109232/#review28414
-----------------------------------------------------------


On March 2, 2013, 7:02 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109232/
> -----------------------------------------------------------
> 
> (Updated March 2, 2013, 7:02 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Dan Vrátil.
> 
> 
> Description
> -------
> 
> is uses the new avatarPixmap() method to display avatars.
> both the list and the tooltip will show gray avatars if offline.. show info is still full colour... intentional...
> 
> 
> This addresses bug 315965.
>     http://bugs.kde.org/show_bug.cgi?id=315965
> 
> 
> Diffs
> -----
> 
>   tooltips/contacttooltip.h 60e8428 
>   tooltips/contacttooltip.cpp 712c4e2 
>   contact-delegate.cpp 810594a 
>   contact-delegate-compact.cpp ee2e668 
> 
> Diff: http://git.reviewboard.kde.org/r/109232/diff/
> 
> 
> Testing
> -------
> 
> offline avatars are gray now... 
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130303/a9f2f7ab/attachment.html>