Review Request 109182: Replace MessageItem with KTp::Message

[David Edmundson]

> On March 2, 2013, 3:24 p.m., David Edmundson wrote:
> > KTp/message.cpp, line 67
> > <http://git.reviewboard.kde.org/r/109182/diff/3/?file=116464#file116464line67>
> >
> >     Can we just use proper d->senderName()
> >     
> >     rather than a hash map.

I'd prefer senderAlias() as it matches Tp::ContactPtr


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109182/#review28388
-----------------------------------------------------------


On March 2, 2013, 8:39 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109182/
> -----------------------------------------------------------
> 
> (Updated March 2, 2013, 8:39 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is the accompanying patch to https://git.reviewboard.kde.org/r/109181/.
> 
> It makes KTp::Messages store sender details as properties (to be used to send the notification). 
> 
> It also adds two methods to KTp::MessageProcessor to append/remove filters. I did this as a quick hack to allow me to test the NotifyFilter. I think we'll have to make KTp::MessageFilter a non singleton class and have it implicitly share the loaded plugins list between instances.
> 
> 
> This addresses bug 315790.
>     http://bugs.kde.org/show_bug.cgi?id=315790
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/messages-model.cpp dc975d0 
>   KTp/message.h 240e498 
>   KTp/message.cpp 7be60e0 
> 
> Diff: http://git.reviewboard.kde.org/r/109182/diff/
> 
> 
> Testing
> -------
> 
> Same as the other patch.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130302/ad10d502/attachment.html>