Review Request 109240: caches processed avatar pixmap

David Edmundson david at davidedmundson.co.uk
Sat Mar 2 14:26:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109240/#review28380
-----------------------------------------------------------

Ship it!



KTp/contact.cpp
<http://git.reviewboard.kde.org/r/109240/#comment21199>

    I'm surprised this compiles, surely it should be find(keyCache(), &avatar);
    
    
    


Double check it compiles, then ship it.

- David Edmundson


On March 2, 2013, 10:50 a.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109240/
> -----------------------------------------------------------
> 
> (Updated March 2, 2013, 10:50 a.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Dan Vrátil.
> 
> 
> Description
> -------
> 
> caches processed avatar pixmap as suggested by david 
> 
> 
> This addresses bug 315969.
>     http://bugs.kde.org/show_bug.cgi?id=315969
> 
> 
> Diffs
> -----
> 
>   KTp/contact.h 0986f42 
>   KTp/contact.cpp 8a0982d 
> 
> Diff: http://git.reviewboard.kde.org/r/109240/diff/
> 
> 
> Testing
> -------
> 
> build... and contact list still shows avatars
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130302/33f91753/attachment.html>


More information about the KDE-Telepathy mailing list