Review Request 109241: Fixed Ctrl+Q shortcut for application quit. Main widget's constructor splitted into several private methods.

Martin Klapetek martin.klapetek at gmail.com
Sat Mar 2 14:18:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109241/#review28379
-----------------------------------------------------------

Ship it!


Please split the shortcut fix into a separate commit

- Martin Klapetek


On March 2, 2013, 12:25 p.m., Roman Nazarenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109241/
> -----------------------------------------------------------
> 
> (Updated March 2, 2013, 12:25 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fixed Ctrl+Q shortcut for application quit by adding action to main window. 
> Also moved telepathy initialization to setupTelepathy() and toolbar initialization to setupToolBar().
> Dual actions moved to setupActions() method.
> 
> 
> This addresses bug 284793.
>     http://bugs.kde.org/show_bug.cgi?id=284793
> 
> 
> Diffs
> -----
> 
>   main-widget.h f5062ee 
>   main-widget.cpp 33de920 
> 
> Diff: http://git.reviewboard.kde.org/r/109241/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Nazarenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130302/706ea963/attachment.html>


More information about the KDE-Telepathy mailing list