Review Request 109231: new method for KTp::Contact avatarPixmap() part 1

[Alin M Elena]

> On March 1, 2013, 4:56 p.m., David Edmundson wrote:
> > KTp/contact.cpp, line 120
> > <http://git.reviewboard.kde.org/r/109231/diff/1/?file=116343#file116343line120>
> >
> >     This all needs to go into a QPixmapCache.
> >     
> >     Otherwise it'll be run each time. You can use the use the avatarToken + "-offline" as the key.
> >     
> >     Files are implicitly cached, the output of this won't be.
> 
> Alin M Elena wrote:
>     I have no idea how to do that.. I will need to read about
> 
> Martin Klapetek wrote:
>     Related: http://doc.qt.digia.com/qq/qq12-qpixmapcache.html

opened bug https://bugs.kde.org/show_bug.cgi?id=315969
will post as a new review


- Alin M


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109231/#review28346
-----------------------------------------------------------


On March 1, 2013, 5:45 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109231/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 5:45 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Dan Vrátil.
> 
> 
> Description
> -------
> 
> adds a method avatarPixmap() to KTp::Contact which returns a colour or gray pixmap based on presence, to be used by contact list.
> 
> 
> This addresses bug 315965.
>     http://bugs.kde.org/show_bug.cgi?id=315965
> 
> 
> Diffs
> -----
> 
>   KTp/Models/contacts-list-model.cpp 692bcfd 
>   KTp/contact.h c332c7d 
>   KTp/contact.cpp 0602200 
>   KTp/types.h 4ef0002 
> 
> Diff: http://git.reviewboard.kde.org/r/109231/diff/
> 
> 
> Testing
> -------
> 
> implemented in contact list and works... 
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130302/bb935324/attachment.html>