Review Request 109231: new method for KTp::Contact avatarPixmap() part 1

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109231/#review28352
-----------------------------------------------------------

Ship it!


Fix those issues and ship it!


KTp/Models/contacts-list-model.cpp
<http://git.reviewboard.kde.org/r/109231/#comment21171>

    call it just avatarPixmap



KTp/contact.h
<http://git.reviewboard.kde.org/r/109231/#comment21173>

    Change this, it's not going to be colored according to presence ;) But just grayscale if offline.



KTp/contact.h
<http://git.reviewboard.kde.org/r/109231/#comment21172>

    remove whitespace



KTp/contact.cpp
<http://git.reviewboard.kde.org/r/109231/#comment21174>

    remove the Tp::Contact::, it's not needed since KTp::Contact derives from Tp::Contact.



KTp/contact.cpp
<http://git.reviewboard.kde.org/r/109231/#comment21175>

    Same here



KTp/types.h
<http://git.reviewboard.kde.org/r/109231/#comment21170>

    Put this under the ContactAvatarPathRole, should be together


- Martin Klapetek


On March 1, 2013, 5:15 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109231/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 5:15 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Dan Vrátil.
> 
> 
> Description
> -------
> 
> adds a method avatarPixmap() to KTp::Contact which returns a colour or gray pixmap based on presence, to be used by contact list.
> 
> 
> This addresses bug 315965.
>     http://bugs.kde.org/show_bug.cgi?id=315965
> 
> 
> Diffs
> -----
> 
>   KTp/Models/contacts-list-model.cpp 692bcfd 
>   KTp/contact.h c332c7d 
>   KTp/contact.cpp 0602200 
>   KTp/types.h 4ef0002 
> 
> Diff: http://git.reviewboard.kde.org/r/109231/diff/
> 
> 
> Testing
> -------
> 
> implemented in contact list and works... 
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130301/bf4ced8a/attachment.html>