Review Request 109231: new method for KTp::Contact avatarPixmap() part 1

[Martin Klapetek]

> On March 1, 2013, 4:55 p.m., Martin Klapetek wrote:
> > KTp/contact.h, line 49
> > <http://git.reviewboard.kde.org/r/109231/diff/1/?file=116342#file116342line49>
> >
> >     Make it const
> 
> Alin M Elena wrote:
>     if I do that I get this 
>     
>     /home/alin/lavello/ktp-common-internals/KTp/contact.cpp: In member function ‘QPixmap KTp::Contact::avatarPixmap() const’:
>     /home/alin/lavello/ktp-common-internals/KTp/contact.cpp:113:28: error: passing ‘const KTp::Contact’ as ‘this’ argument of ‘void KTp::Contact::avatarToGray(QPixmap&)’ discards qualifiers [-fpermissive]
>     
>     then of I do what suggests and constify that too... 
>     /home/alin/lavello/ktp-common-internals/KTp/contact.cpp: In member function ‘QPixmap KTp::Contact::avatarPixmap() const’:
>     /home/alin/lavello/ktp-common-internals/KTp/contact.cpp:113:28: error: passing ‘const KTp::Contact’ as ‘this’ argument of ‘void KTp::Contact::avatarToGray(const QPixmap&)’ discards qualifiers [-fpermissive]
>     /home/alin/lavello/ktp-common-internals/KTp/contact.cpp: In member function ‘void KTp::Contact::avatarToGray(const QPixmap&)’:
>     /home/alin/lavello/ktp-common-internals/KTp/contact.cpp:128:36: error: passing ‘const QPixmap’ as ‘this’ argument of ‘QPixmap& QPixmap::operator=(const QPixmap&)’ discards qualifiers [-fpermissive]
>     /home/alin/lavello/ktp-common-internals/KTp/contact.cpp:129:29: error: passing ‘const QPixmap’ as ‘this’ argument of ‘void QPixmap::setMask(const QBitmap&)’ discards qualifiers [-fpermissive]
>     make[2]: *** [KTp/CMakeFiles/ktpcommoninternalsprivate.dir/contact.cpp.o] Error 1
>     make[1]: *** [KTp/CMakeFiles/ktpcommoninternalsprivate.dir/all] Error 2
>     make: *** [all] Error 2
>     
>     so I do not know what to say..
>     
>     
>

Actually it shouldn't be const, I meant to remove that comment, but forgot, sorry.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109231/#review28345
-----------------------------------------------------------


On March 1, 2013, 5:15 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109231/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 5:15 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Dan Vrátil.
> 
> 
> Description
> -------
> 
> adds a method avatarPixmap() to KTp::Contact which returns a colour or gray pixmap based on presence, to be used by contact list.
> 
> 
> This addresses bug 315965.
>     http://bugs.kde.org/show_bug.cgi?id=315965
> 
> 
> Diffs
> -----
> 
>   KTp/Models/contacts-list-model.cpp 692bcfd 
>   KTp/contact.h c332c7d 
>   KTp/contact.cpp 0602200 
>   KTp/types.h 4ef0002 
> 
> Diff: http://git.reviewboard.kde.org/r/109231/diff/
> 
> 
> Testing
> -------
> 
> implemented in contact list and works... 
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130301/a70fb61e/attachment-0001.html>