Review Request 111256: Import the KPeople KTP integration plugins

David Edmundson david at davidedmundson.co.uk
Wed Jun 26 14:33:17 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111256/
-----------------------------------------------------------

(Updated June 26, 2013, 2:33 p.m.)


Review request for Telepathy.


Changes
-------

Avoid  the "git commit -a" issue :D


Description
-------

Import the KPeople KTP integration plugins

There are two plugins, one for the datasource which provides
IM data in real time.

The other is an actions plugin which provides actions that can be started on a PersonsData.

We need to provide KTp integration into libkpeople in a plugin, but we also want to access this
singleton of accounts/contacts from the other plugin and from the KTp Models. To do this a static library
ktpkpeople is created and everything links against that.

KTp Models the actions plugin and the im data source all link against this.


Diffs (updated)
-----

  CMakeLists.txt a83069d59fed945d04560662e3a307ef33b28332 
  KTp/Models/CMakeLists.txt 720a5b02465b825b08d12d7c43342ad1ba69c9d1 
  kpeople/actionsplugin/CMakeLists.txt PRE-CREATION 
  kpeople/actionsplugin/implugin.h PRE-CREATION 
  kpeople/actionsplugin/implugin.cpp PRE-CREATION 
  kpeople/actionsplugin/ktp_kpeople_plugin.desktop PRE-CREATION 
  kpeople/common/CMakeLists.txt PRE-CREATION 
  kpeople/common/impersonsdatasource.h PRE-CREATION 
  kpeople/common/impersonsdatasource.cpp PRE-CREATION 
  kpeople/datasourceplugin/CMakeLists.txt PRE-CREATION 
  kpeople/datasourceplugin/im_persons_data_source_plugin.desktop PRE-CREATION 
  kpeople/datasourceplugin/impersonsdatasourceplugin.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111256/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130626/4cec25e4/attachment.html>


More information about the KDE-Telepathy mailing list