Review Request 111157: groupwise account ui refactoring (on behalf of Daniel Cohen)

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111157/#review34808
-----------------------------------------------------------


The code looks fine.

I would just remove the placeholder text in username field, we don't use it anywhere else.

- Dan Vrátil


On June 21, 2013, 1:42 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111157/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 1:42 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> groupwise account ui refactoring
> 
> ---
> Received this in an email. Added to RB, replying with a link back to original author.
> 
> 
> Diffs
> -----
> 
>   plugins/haze/CMakeLists.txt 0d786470a6771e8644852b514048c6878f438a0f 
>   plugins/haze/groupwise-advanced-settings-widget.h PRE-CREATION 
>   plugins/haze/groupwise-advanced-settings-widget.cpp PRE-CREATION 
>   plugins/haze/groupwise-advanced-settings-widget.ui PRE-CREATION 
>   plugins/haze/groupwise-main-options-widget.h PRE-CREATION 
>   plugins/haze/groupwise-main-options-widget.cpp PRE-CREATION 
>   plugins/haze/groupwise-main-options-widget.ui PRE-CREATION 
>   plugins/haze/haze-account-ui-plugin.cpp 8a4b2418d594a690c59e94dcbecf00d81e0bde5b 
>   plugins/haze/haze-groupwise-account.h PRE-CREATION 
>   plugins/haze/haze-groupwise-account.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111157/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/20/tmp.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130621/2d32a501/attachment.html>