Review Request 110948: Fix hovering the delegate button

[Andrea Scarpino]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110948/#review34743
-----------------------------------------------------------


Now I get:
file:///usr/local/share/apps/plasma/plasmoids/org.kde.ktp-chat/contents/ui/ConversationDelegateButton.qml:55: Unable to assign null to int

Default acceptedButtons value is Qt.LeftButton; I tried to replace the null assignment with it, but got:
file:///usr/local/share/apps/plasma/plasmoids/org.kde.ktp-chat/contents/ui/main.qml:61: TypeError: Result of expression 'conversationsModel' [null] is not an object.

- Andrea Scarpino


On June 14, 2013, 1:20 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110948/
> -----------------------------------------------------------
> 
> (Updated June 14, 2013, 1:20 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch solves/workarounds a bug with PlasmaCore.ToolTip that would make it not to forward properly the hover event to the button thus not making it render properly on hover.
> 
> I searched through the code and I saw that most people were using it on a MouseArea and it does seem to solve the problem.
> The whole concept of how these ToolTip work seem broken to me so I don't think it's worth fixing or figuring further.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegateButton.qml 619b19a 
> 
> Diff: http://git.reviewboard.kde.org/r/110948/diff/
> 
> 
> Testing
> -------
> 
> It looks nice when hovering the plasmoid now.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130620/83d09ddd/attachment.html>