Review Request 111091: Add "Always Ask" option for filetransfer destination directory

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111091/
-----------------------------------------------------------

(Updated June 20, 2013, 11:34 a.m.)


Review request for Telepathy.


Changes
-------

The Handler now remember last selected download directory. The last selected directory is intentionally stored in a separate config entry (not in "downloadDirectory"), so that it does not touch user configuration in KCM. 


Description
-------

Implements support for "Always Ask" for filetransfer destination directory option.

The hack with __k__onDownloadDirectoryCancelled() is necessary because KDirSelectDialog::result() always returns 0 and buttonClicked() signal is emitted even when "New Folder" button is clicked and handling that would make the code more complicated.


This addresses bug 295937.
    http://bugs.kde.org/show_bug.cgi?id=295937


Diffs (updated)
-----

  src/CMakeLists.txt ebd892c 
  src/filetransfer-handler.cpp 74c701e 
  src/handle-incoming-file-transfer-channel-job.h d5e53c4 
  src/handle-incoming-file-transfer-channel-job.cpp 7a15237 

Diff: http://git.reviewboard.kde.org/r/111091/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130620/db938bda/attachment.html>