Review Request 111128: Add CMake files to find libkpeople

[Aleix Pol Gonzalez]

> On June 19, 2013, 5:05 p.m., Aleix Pol Gonzalez wrote:
> > KPeople is already installing a FindKPeople.cmake file already.
> > 
> > Also it's a bit more complete that this one, since it offers KPEOPLE_WIDGETS_LIBRARY and some others IIRC.
> 
> David Edmundson wrote:
>     oh..that's handy!
> 
> Daniele E. Domenichelli wrote:
>     That's wrong, it should install a KPeopleConfig.cmake and some other stuff, and it won't require the FindKPeople.cmake
> 
> Daniele E. Domenichelli wrote:
>     see http://cmake.org/Wiki/CMake/Tutorials/Packaging

It's a different way of doing it, probably a better one

I'd suggest to use the finder we already have and when somebody wants to do it better, then do the Config thing. It's quite simple.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111128/#review34689
-----------------------------------------------------------


On June 19, 2013, 4:13 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111128/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 4:13 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add CMake files to find libkpeople
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a83069d59fed945d04560662e3a307ef33b28332 
>   cmake/modules/FindKPeople.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111128/diff/
> 
> 
> Testing
> -------
> 
> I get 
> -----------------------------------------------------------------------------
> -- The following external packages were located on your system.
> -- This installation will have the extra features provided by these packages.
> -----------------------------------------------------------------------------
>    * KPeople - Support for KDE Contact Aggregation
> 
> ---------------------------------------------------------
> 
> 
> scummos gets
> 
> [17:11] <scummos> -- The following OPTIONAL packages could NOT be located on your system.
> [17:11] <scummos> -- Consider installing them to enable more features from this software.
> [17:11] <scummos> -----------------------------------------------------------------------------
> [17:11] <scummos>    * KPeople  <https://projects.kde.org/libkpeople>
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130619/f82391f2/attachment.html>