Review Request 111109: Only show tooltips when we are the active window

Martin Klapetek martin.klapetek at gmail.com
Wed Jun 19 09:37:08 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111109/#review34658
-----------------------------------------------------------

Ship it!



tooltips/tooltipmanager.cpp
<http://git.reviewboard.kde.org/r/111109/#comment25447>

    no space inside


- Martin Klapetek


On June 19, 2013, midnight, David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111109/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, midnight)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Only show tooltips when we are the active window
> 
> I want to put this in 0.6.x too.
> 
> (I should probably also backport this to SystemSettings where we stole the original code from)
> 
> 
> Diffs
> -----
> 
>   tooltips/tooltipmanager.cpp 961dbfa187abf2b0e5d9149ee3477de066767452 
> 
> Diff: http://git.reviewboard.kde.org/r/111109/diff/
> 
> 
> Testing
> -------
> 
> Tooltips appear when we want them, don't show it I hover whilst another window is active. They hide if I have a hover then alt+tab to another window.
> 
> qDebug() showed both code changes are needed.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130619/609be2a5/attachment.html>


More information about the KDE-Telepathy mailing list